Include optional dependencies from dtscalibration dependencies #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use "xarray[parallel,accel]" instead of filling up the dtscalibration dependency list with optional xarray dependencies.
|
I see your branch is out of date. Want to first handle off #187 and then redo this PR? 😇 |
Sure! No rush |
|
It would make for a cleaner commit (just a single commit to Seeing as we directly import from dask, I would leave that a direct dependency. Same for pandas. Things we don't directly import (flox) can be installed with the extras options for xarray. |
As it only used by statsmodels, and now included in the statsmodels dependencies.
It is not directly used by our scripts and cannot identify it as an optional dependency of one of our dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "xarray[parallel,accel]" instead of filling up the dtscalibration dependency list with optional xarray dependencies.